Repository navigation
Keep docs:ready when it was applied after the docs check started - #47
Open
fivetran-data-model-bot wants to merge 1 commit into
Open
fivetran-data-model-bot wants to merge 1 commit into
fivetran-data-model-bot wants to merge 1 commit into
Conversation
Since changelog entries moved to .changes/*.yml, the usual flow is to push the entry and apply docs:ready seconds later. The check for that push then removed the label even though it had already started a docs run, so the label no longer reflected that docs were current. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.changes/*.yml(Changelog poc/initial test #40), the usual flow is to push the entry and applydocs:readya few seconds later..changes/edits count as relevant, so the check for that push reports stale (correctly) and then removes the label, even though the label already started a docs run for that commit. After that run succeeds, the label is gone while the docs are current.docs:ready,check-docs-current.ymlnow compares the label's most recentlabeledevent with when this check run was triggered (created_at, orrun_started_atfor a re-run). If the label is newer, the check leaves it for the docs run. If that run fails,generate-docs.ymlalready removes the label.docs/generatedstatus is unchanged: it still reports stale until the docs run pushes.Real-world repro
dbt_intercom#91 on 11/3:
50ffd29(only.changes/1.8.1.yml) pushed at 17:16:02, and its check started at 17:16:11.docs:readyapplied at 17:16:13, and the docs run started at 17:16:16.caba985at 17:17:38, and the check reported "Docs and changelog current", but the label stayed off.Related
Pairs with #46, which covers a different race: two docs runs from applying the label twice. This PR covers the check from your own push removing a label you just applied. #46's "Not covered here" section describes this case.
Test plan
.changes/edit and applydocs:readyright away. The label should stay through the docs run, anddocs/generatedshould end green.🤖 Generated with Claude Code